Backport Fix circular require warning in belongs_to.rb #8601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3-0-stable #8601 +/- ##
=============================================
Coverage ? 99.19%
=============================================
Files ? 194
Lines ? 4962
Branches ? 0
=============================================
Hits ? 4922
Misses ? 40
Partials ? 0 ☔ View full report in Codecov by Sentry. |
tagliala
changed the title
javierjulio
changed the title
When running specs with `RUBYOPTS='-w'`, numerous warnings are generated due to a circular require between: - `lib/active_admin/resource/belongs_to.rb` - `lib/active_admin/resource.rb` The warning message is: ``` warning: loading in progress, circular require considered harmful - ./lib/active_admin/resource.rb ``` Based on the code history, there is no specific reason for the inverse require from `belongs_to` to `resource`. This change removes the unnecessary require to eliminate the warnings. Backports #8598 to `3-0-stable` branch
tagliala
force-pushed
the
backport-8599
branch
from
c8d7a76 to
5b53b0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running specs with
RUBYOPTS='-w', numerous warnings are generated due to a circular require between:lib/active_admin/resource/belongs_to.rblib/active_admin/resource.rbThe warning message is:
Based on the code history, there is no specific reason for the inverse require from
belongs_totoresource.This change removes the unnecessary require to eliminate the warnings.