Display full job name and nested workflow details in log

[nicholasbergesen]

This forms part of the work being done for the nested workflow feature. Jobs that are nested more than 1 level in depth have their job name truncated in the UI. The change displays the full job name as well as the calling workflow ref and inputs that were passed in, in the UI and raw logs

Complete job name:

Calling workflow ref with inputs:

Expanded:

Raw logs:

actions-dotnet change: https://github.com/github/actions-dotnet/pull/12910

Closes: https://github.com/github/c2c-actions-policy/issues/580
Epic: https://github.com/github/c2c-actions-policy/issues/399

[yujincat]

In the example snapshot, I believe we used ./.github/workflows/end.yml but it is adding the nwo.
What does it look like when we refer the workflow with nwo and version? Does it show the version as well?

[nicholasbergesen]

remove unused JobWorkflowRef property

[nicholasbergesen]

add mapping to dataWorkflowFilePathRaw in constructor

[nicholasbergesen]

In the example snapshot, I believe we used ./.github/workflows/end.yml but it is adding the nwo. What does it look like when we refer the workflow with nwo and version? Does it show the version as well?

@yujincat if I use github/public-server/.github/workflows/end.yml@main in the workflow file it displays github/public-server/.github/workflows/end.yml in the log, with the nwo but without the version.

[TingluoHuang]

Why do we need to log this info to the set up job step?
We might need to have PM sign off on this kind of change since these are informational message that is not really scoped for how the runner set up the job.

[yujincat]

@TingluoHuang We already have discussed this with @chrispat before, hence we are working on this. The reason we want to log this is we want to provide more context of workflow execution in the log so that the users can understand it; mostly reusable/nested workflows perspective.

Users may want to know what inputs they are given. I thin it makes sense to have that in the "set up job" section because the inputs apply per job. Also we want to show the text given from user in the uses field in the yaml file to provide more context of using reusable workflows for this job.

Providing the full job name is also what we want, as the job name using nested workflows will be truncated in the UI.

@nicholasbergesen I think we should check if we want to make this change for all workflows or reusable case only.

[nicholasbergesen]

I've moved the display of complete job name inside the check on system.workflowFileFullPath so it will only display in the log for reusable workflows.

[nicholasbergesen]

@TingluoHuang Instead of using Set up job Do you think it would be better to create a new section? Something along the lines of Job trigger or Job source for displaying details relating to how the job was called?

[chrispat]

I think this is good. We already display a bunch of information in that area that has nothing to do with the runner such as secret source and token permissions.

[ajaykn]

Looks good to me 🚀