-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include current runner status while getting messages #2026
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2651740
to
47942c6
Compare
There's no description on the PR. What issue is this fixing? |
47942c6
to
151eae2
Compare
151eae2
to
0b9cf70
Compare
TingluoHuang
approved these changes
Jul 28, 2022
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Aug 14, 2024
* get messages with runner status * fixed l0 tests * PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Current PR is to send an additional parameter that indicates the current runner status while getting messages. This will help to update the runner status in the broker.
When runner status is changed from idle to busy or busy to idle, it cancels the current request to get messages and creates a new request with the corresponding runner status.
Current changes are behind FF by using the environment variable
USE_BROKER_FLOW