Pass jobId to the actionsDownloadInfo controller
#1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ActionReferenceList actionReferenceList, | ||
| object userState = null, | ||
| CancellationToken cancellationToken = default) | ||
| { | ||
| HttpMethod httpMethod = new HttpMethod("POST"); | ||
| Guid locationId = new Guid("27d7f831-88c1-4719-8ca1-6a061dad90eb"); | ||
| object routeValues = new { scopeIdentifier = scopeIdentifier, hubName = hubName, planId = planId }; | ||
| object routeValues = new { scopeIdentifier = scopeIdentifier, hubName = hubName, planId = planId, jobId = jobId }; |
There was a problem hiding this comment.
will this new route without versioning break compat between the latest runner and old GHES.
There was a problem hiding this comment.
If it is a query parameter change without route value , would it still break the compat and do we need GHES testing in that case?
There was a problem hiding this comment.
I would suggest you always test GHES with any REST API changes.
lokesh755
reviewed
Feb 4, 2022
Co-authored-by: Lokesh Gopu <[email protected]>
TingluoHuang
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In order to have the job level telemetry in the github warehouse,
jobIdneed to be passed to this table -hive_hydro.hydro.github_actions_v0_resolve_action_requestImplementation
jobIdis being passed as a query parameter to the controller while downloading the actions info.jobIdwill be accepted and added tohive_hydro.hydro.github_actions_v0_resolve_action_request.jobId(executionContext.Root.Id) by matching it with the one from CustomerIntelligenceHelper.cs👉ADR for detailed implementation.
Tracking items -
Other PRs