This repository has been archived by the owner on May 3, 2022. It is now read-only.
Throw HttpClientError instead of Error #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failing because of postmanlabs/httpbin#617 |
JojOatXGME
reviewed
Aug 18, 2020
| super(message) | ||
| this.name = 'HttpClientError' | ||
| this.statusCode = statusCode | ||
| Object.setPrototypeOf(this, HttpClientError.prototype) |
There was a problem hiding this comment.
I took a short look into the pull request and was wondering what this line is about. Isn't it redundant? I thought the prototype of this (in a constructor) is <class>.prototype by default.
There was a problem hiding this comment.
Apparently it's to fix a TypeScript issue - https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#extending-built-ins-like-error-array-and-map-may-no-longer-work
There was a problem hiding this comment.
Interesting. Didn't know about this issue. Thanks for your reply.
dhadka
force-pushed
the
dhadka/typed-error
branch
from
3fcf2a8 to
7d62506
Compare
bryanmacfarlane
approved these changes
Aug 26, 2020
dhadka
force-pushed
the
dhadka/typed-error
branch
from
88d6f46 to
9210aa3
Compare
dhadka
force-pushed
the
dhadka/typed-error
branch
from
9210aa3 to
55850f1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
<verb>Jsonhelper methods throw an Error when the server responds with a non-zero status code. They also attach the status code and result as properties.This, however, is not compatible with TypeScript strict type checking. As a result, code depending on
http-clientthat use strict type checking (such asactions/toolkit) can't read the status code and result properties without resorting to TypeScript hacks, such as casting the error object toanyand ignoring the resulting lint warnings.This PR adds a new error subclass,
HttpClientError, which properties to store the status code and result. Throwing a different error type also lets callers distinguish between errors related to the API call from other generic errors, such as socket errors.