Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: include sha in canary version #1744

Merged
merged 1 commit into from
Aug 24, 2022
Merged

ci: include sha in canary version #1744

merged 1 commit into from
Aug 24, 2022

Conversation

toast-gear
Copy link
Collaborator

@toast-gear toast-gear commented Aug 23, 2022 •
edited
Loading

Given the canary tag is mutable it might be handy to include the SHA in the version so it's easier to be sure what canary code you're running.

@toast-gear toast-gear requested a review from mumoshu as a code owner August 23, 2022 18:47
mumoshu
mumoshu approved these changes Aug 24, 2022
View reviewed changes
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for the improvement!

@mumoshu mumoshu merged commit 0cac005 into master Aug 24, 2022
@mumoshu mumoshu deleted the ci/canary-sha-version branch August 24, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumoshu mumoshu mumoshu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toast-gear @mumoshu