Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Metric Types and typos #1719

Merged
merged 3 commits into from
Aug 15, 2022

Conversation

debugger24
Copy link
Contributor

@debugger24 debugger24 commented Aug 14, 2022

  • FIX few typos
  • Add PercentageRunnersBusy in possible values for MetricSpec Type

@debugger24 debugger24 force-pushed the feature/update-helm-chart-desc branch from 3818b4e to 8139375 Compare August 14, 2022 13:38
mumoshu
mumoshu previously approved these changes Aug 15, 2022
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for the fixes 👍

@mumoshu
Copy link
Collaborator

mumoshu commented Aug 15, 2022

@debugger24 Can you also update the description for the type filed within config/crd/bases/actions.summerwind.dev_horizontalrunnerautoscalers.yaml so that CI passes?

@debugger24
Copy link
Contributor Author

Oops, missing that one. Fixed now.

@debugger24 debugger24 requested a review from mumoshu August 15, 2022 04:22
@mumoshu mumoshu merged commit 538e278 into actions:master Aug 15, 2022
@mumoshu
Copy link
Collaborator

mumoshu commented Aug 15, 2022

Thanks again for the fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants