-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add queue size limit to github webhook server helm template #1712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM beyond the docs need updating charts/actions-runner-controller/readme.md
Hey thanks for the review |
Co-authored-by: Yusuke Kuoka <[email protected]>
@debugger24 @mumoshu Thanks for the review and comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies I've not been on this, work is busy.
I am a believer of convention over configuration. We historically have not put the default in the values.yaml docs if it's set in the app itself. Perhaps that was mistake but I'd prefer for us to be consistent so could we:
- remove the stated default from the docs as it's inconsistent with the rest of the doc
- remove
## Queue limit size override, by default its 100
from the values.yaml as this is the same thing as point 1
I'm fine with the commented out queueLimit: 100
in the values.yaml
@toast-gear I've updated the value file and deleted the comment also enabled the queuelimit value 100 to be active |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks a lot for your contribution! @Sajadorouji However, we do have some inconsistencies in other values within the same file, like, we probably want to comment out the default |
We recently hit the queue size limit that is 100 by default and as i find out there is no way to pass the value through the helm chart
Here is a fix to enable users to add their queue size limit in case of need