New Rule: Create Semantic Focus (a20046) #559

ramitgarg · 2019-05-16T20:59:10Z

<< Describe the changes >>

Closes issue: (ADD ISSUE NUMBER HERE)

Guidance for the PR (pull request) creator

When creating PR:

Make sure you requesting to pull a issue/feature/bugfix branch (right side) to the master branch (left side).

After creating PR:

Add yourself (and co-authors) as "Assignees" for PR
Add label to indicate if it's a Rule, Definition or Chore (more to the administrative side)
Add relevant project (e.g. "Q3 2018 Status") to PR
OPTIONAL: If you want anyone in particular to review your pull request, assign them as "Reviewers".
Close the issue that the PR resolves (and make sure the issue is referenced in the top of this comment)

How to Review And Approve

Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.

WilcoFiers · 2019-05-17T12:11:07Z

Scemantic Focus

+
+## Applicability
+
+The rule applies to all element in the sequential focus navigation excepts scrollable content element.


"all elements" is pretty vague. I propose "all HTML and SVG elements"

"sequential focus navigation" must be defined

"scrollable content element" must be defined

[sequential focus navigation](https://www.w3.org/TR/html/editing.html#sec-sequential-focus-navigation

Scemantic Focus

WilcoFiers · 2019-05-17T12:16:04Z

Scemantic Focus

+
+## Assumptions
+
+- Giving focus to scrollable content elements is the only way to scroll non interactive content using a keyboard.


I don't think I understand why this is an assumption. Can you clarify?

It would have been better to have this as note in the applicability instead of an assumption. But after reviewing the definition of focusable are I don't think this is needed, given that if a scrollable region of an element is focusable, then it should have a semantic role so that users of AT can understand what role that region plays.

Scemantic Focus

WilcoFiers · 2019-05-17T12:19:20Z

Scemantic Focus

+Element in sequential navigation doesnot have semantic role
+
+```html
+<a href="#desc" tabindex="0" aria-hidden="true">More</a>


This scenario is addressed by a different role: https://act-rules.github.io/rules/6cfa84 I suggest that we avoid overlap by adding "that is included in the accessibility tree" to the applicability.

WilcoFiers · 2019-05-17T12:23:49Z

Scemantic Focus

+#### Passed Example 4
+
+
+### Failed


Add a test where you override the role of an element that's focusable by default.

WilcoFiers · 2019-05-17T12:24:17Z

Scemantic Focus

+<div href="#desc" role="presentation" tabindex="0">More</div>
+```
+
+### Inapplicable 


Add a test where you disable an element to remove it from focus sequence.

Scemantic Focus

WilcoFiers · 2019-05-17T12:30:08Z

Scemantic Focus

+ This rule checks that every element part of the sequential focus navigation has a semantic role.
+
+accessibility_requirements: 
+  wcag20:2.4.4: # Link Purpose (In Context) 


I don't believe this is a failure of 2.4.4. More generally, while I'm totally on board with this rule, I don't believe this is a failure of WCAG 2.1 at all. I've had that discussion in the past, this rule looks quite a lot like something we have in axe-core today. Here's a link to that conversation:
dequelabs/axe-core#632

Anne suggested 4.1.2

Anne suggested 4.1.2

This would also not fail 4.1.2

4.1.2 asks a role of all "user interface components". But if a piece of text with a span on it suddenly receives focus (because of tabindex for example) that doesn't make that piece of text a user interface component because it doesn't control anything.

I agree that it is a good rule (because most of the time it will point to a 4.1.2 violation) but it is currently not necessarily a WCAG failure to fail this rule.

Scemantic Focus

annethyme · 2019-06-12T12:49:04Z

Siteimprove doesn't think this rule is testing for anything required by WCAG.

ShadowBB · 2019-06-25T13:30:21Z

Although I think this is an interesting rule that can definitely indicate accessibility failures, it probably doesn't explicitly test anything in WCAG.

@WilcoFiers , I think this also depends on the definition of "user interface components" because if user interface components include things that receive focus, those things will need a role or fail 4.1.2.

Scemantic Focus

Revised the rule addressing previous comments. As an outcome of the revision, I do believe that now this addressed 4.1.2. More comments welcomed

semantic-focus-a20046.md

EmmaJP

If everyone else is agreed that this rule would be part of checks for conformance for 4.1.2, which I'm OK with, then I think this is looking good. I've suggested a grammatical change in the description, but the rest seems to be fine.

ShadowBB · 2019-08-05T10:51:55Z

semantic-focus-a20046.md

+ This rule checks that every element that is part of the sequential focus navigation order has a semantic role.
+
+accessibility_requirements: 
+  wcag20:4.1.2: # Name, Role, Value (A)


I would (still) not say this fails WCAG 4.1.2.

A Div with tabindex is not a user interface component and doesn't need a role.

CLAassistant · 2019-08-13T10:00:42Z

All committers have signed the CLA.

jeeyyy · 2019-09-11T09:43:04Z

@ramitgarg any updates on these?

carlosapaduarte · 2019-09-11T10:47:16Z

@JKODU we decided last week to drop this one since it does not address any SC. do you want us to keep working on it?

jeeyyy · 2019-10-02T08:12:42Z

This seems to have "Should we proceed" for a while? Have we reached a conclusion on the same?

carlosapaduarte · 2019-10-02T09:13:27Z

As far as I recall, the last time this was discussed in a meeting, the conclusion was to leave it on hold because this is not testing a SC, but it's just a best practice.

Create Scemantic Focus

691f4a9

ramitgarg changed the title ~~Create Scemantic Focus~~ New Rule: Create Scemantic Focus May 16, 2019

Update Scemantic Focus

8faa42c

WilcoFiers requested changes May 17, 2019

View reviewed changes

jeeyyy changed the title ~~New Rule: Create Scemantic Focus~~ New Rule: Create Semantic Focus May 29, 2019

jeeyyy suggested changes Jun 5, 2019

View reviewed changes

Scemantic Focus Outdated Show resolved Hide resolved

Scemantic Focus Outdated Show resolved Hide resolved

Scemantic Focus Outdated Show resolved Hide resolved

Merge branch 'develop' into patch-1

7fb0730

jeeyyy added the Agenda item label Jun 12, 2019

jeeyyy removed the Agenda item label Jun 13, 2019

annethyme added the Should we proceed? Do people agree that this rule tests for WCAG and that the general concept is good? label Jun 13, 2019

jeeyyy added the Agenda item label Jul 10, 2019

EmmaJP reviewed Jul 11, 2019

View reviewed changes

Scemantic Focus Outdated Show resolved Hide resolved

carlosapaduarte self-assigned this Jul 11, 2019

annethyme added the Rule Use this label for a new rule that does not exist already label Jul 12, 2019

annethyme added the New (unpublished) label Jul 19, 2019

WilcoFiers removed the Agenda item label Jul 24, 2019

carlosapaduarte added 3 commits July 25, 2019 18:28

Update and rename Scemantic Focus to semantic-focus-a20046.md

f97c0fe

Update semantic-focus-a20046.md

42215ed

Update semantic-focus-a20046.md

a309504

Revised the rule addressing previous comments. As an outcome of the revision, I do believe that now this addressed 4.1.2. More comments welcomed

carlosapaduarte requested review from jeeyyy, WilcoFiers, annethyme, EmmaJP and ShadowBB July 25, 2019 19:49

carlosapaduarte added the reviewers wanted label Jul 25, 2019

EmmaJP reviewed Jul 26, 2019

View reviewed changes

semantic-focus-a20046.md Outdated Show resolved Hide resolved

EmmaJP previously approved these changes Jul 26, 2019

View reviewed changes

Update semantic-focus-a20046.md

b762a1f

carlosapaduarte dismissed EmmaJP’s stale review via b762a1f August 4, 2019 18:05

ShadowBB suggested changes Aug 5, 2019

View reviewed changes

annethyme changed the title ~~New Rule: Create Semantic Focus~~ New Rule: Create Semantic Focus (a20046) Aug 14, 2019

jeeyyy removed the New (not published) label Sep 12, 2019

Merge branch 'develop' into patch-1

d2e527e

jeeyyy added the Agenda item label Oct 2, 2019

carlosapaduarte added On hold and removed Should we proceed? Do people agree that this rule tests for WCAG and that the general concept is good? reviewers wanted Agenda item labels Oct 2, 2019

carlosapaduarte closed this Oct 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Rule: Create Semantic Focus (a20046) #559

New Rule: Create Semantic Focus (a20046) #559

ramitgarg commented May 16, 2019

WilcoFiers May 17, 2019

annethyme Jun 7, 2019

WilcoFiers May 17, 2019

carlosapaduarte Jul 25, 2019

WilcoFiers May 17, 2019

WilcoFiers May 17, 2019

WilcoFiers May 17, 2019

WilcoFiers May 17, 2019

EmmaJP Jul 11, 2019 •

edited

Loading

ShadowBB Jul 16, 2019

annethyme commented Jun 12, 2019

ShadowBB commented Jun 25, 2019

EmmaJP left a comment

ShadowBB Aug 5, 2019

CLAassistant commented Aug 13, 2019 •

edited

Loading

jeeyyy commented Sep 11, 2019

carlosapaduarte commented Sep 11, 2019

jeeyyy commented Oct 2, 2019

carlosapaduarte commented Oct 2, 2019 •

edited

Loading


		## Applicability

		The rule applies to all element in the sequential focus navigation excepts scrollable content element.


		## Assumptions

		- Giving focus to scrollable content elements is the only way to scroll non interactive content using a keyboard.

New Rule: Create Semantic Focus (a20046) #559

New Rule: Create Semantic Focus (a20046) #559

Conversation

ramitgarg commented May 16, 2019

Guidance for the PR (pull request) creator

How to Review And Approve

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EmmaJP Jul 11, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annethyme commented Jun 12, 2019

ShadowBB commented Jun 25, 2019

EmmaJP left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CLAassistant commented Aug 13, 2019 • edited Loading

jeeyyy commented Sep 11, 2019

carlosapaduarte commented Sep 11, 2019

jeeyyy commented Oct 2, 2019

carlosapaduarte commented Oct 2, 2019 • edited Loading

EmmaJP Jul 11, 2019 •

edited

Loading

CLAassistant commented Aug 13, 2019 •

edited

Loading

carlosapaduarte commented Oct 2, 2019 •

edited

Loading