Skip to content

Commit

Permalink
[FIX] website_sale: add message to translation
Browse files Browse the repository at this point in the history
Steps to reproduce:
- install the e-commerce module
- in General settings, add and switch French -or any- language
- Go to website
- Under e-commerce > product in the menu bar
- click on any product
- click on go to website smart button
- click on edit button to edit the website page
- choose any block to insert, You can notice the message (DROP BUILDING BLOCKS HERE TO MAKE THEM AVAILABLE ACROSS ALL PRODUCTS) stays in English

Investigation
- The message is not add to website_sale.pot file, as the message string passed to an attribute not an actual string inside a tag.

opw-3573881

closes odoo#145363

X-original-commit: 87177e6
Signed-off-by: Ali Hassan Youssef (alhy) <[email protected]>
  • Loading branch information
AH-Yussef committed Dec 7, 2023
1 parent 8c2903c commit 144893c
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 1 deletion.
5 changes: 5 additions & 0 deletions addons/website_blog/i18n/website_blog.pot
Original file line number Diff line number Diff line change
Expand Up @@ -1179,6 +1179,11 @@ msgid ""
"We are a team of passionate people whose goal is to improve everyone's life."
msgstr ""

#. module: website_blog
#: model_terms:ir.ui.view,arch_db:website_blog.blog_post_content
msgid "WRITE HERE OR DRAG BUILDING BLOCKS"
msgstr ""

#. module: website_blog
#: model:ir.model,name:website_blog.model_website
#: model:ir.model.fields,field_description:website_blog.field_blog_blog__website_id
Expand Down
5 changes: 5 additions & 0 deletions addons/website_sale/i18n/website_sale.pot
Original file line number Diff line number Diff line change
Expand Up @@ -1092,6 +1092,11 @@ msgstr ""
msgid "Default (1/1)"
msgstr ""

#. module: website_sale
#: model_terms:ir.ui.view,arch_db:website_sale.product
msgid "DROP BUILDING BLOCKS HERE TO MAKE THEM AVAILABLE ACROSS ALL PRODUCTS"
msgstr ""

#. module: website_sale
#: model:ir.model.fields,field_description:website_sale.field_website__currency_id
msgid "Default Currency"
Expand Down
2 changes: 1 addition & 1 deletion odoo/tools/translate.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def encode(s):
TRANSLATED_ATTRS = dict.fromkeys({
'string', 'add-label', 'help', 'sum', 'avg', 'confirm', 'placeholder', 'alt', 'title', 'aria-label',
'aria-keyshortcuts', 'aria-placeholder', 'aria-roledescription', 'aria-valuetext',
'value_label', 'data-tooltip',
'value_label', 'data-tooltip', 'data-editor-message',
}, lambda e: True)

def translate_attrib_value(node):
Expand Down

0 comments on commit 144893c

Please sign in to comment.