Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codependencies #19

Merged
merged 1 commit into from
May 12, 2022
Merged

Codependencies #19

merged 1 commit into from
May 12, 2022

Conversation

len-foss
Copy link
Contributor

@len-foss len-foss commented Dec 30, 2021

This PR adds a command to list co-dependencies of a set of addons, i.e. the set of addons that depend on them.

In most cases, to test a feature branch it is sufficient to test the modified modules and their co-dependencies.
Using #20, to put both together:
manifestoo --addons-path odoo/addons/ -g master list-codepends

No tests added yet.

Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

A few comments at this stage (I've not done a full review it, just skimmed through it).

Would you mind doing two PRs for the git and co-dependencies parts ? It will help (me at least) focusing the review.

.gitignore Outdated
Session.vim
Sessionx.vim
*~
\#*\#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to keep my projects editor-agnostic. So I generally recommend putting this in your personal ~/.gitignore via ~/.gitconfig, such as:

[core]
	editor = vim
	excludesfile = ~/.gitignore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if that was the workaround you would suggest :-) Sure, will do it.

include_selected: bool = typer.Option(
True,
"--include-selected",
help="Print the selected addons along with their co-dependencies.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain here what co-dependencies are ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given a relation, it's dual (co-relation) is obtained by inverting the arrows. But I will put an explanation.

@len-foss len-foss changed the title Codependencies and Git features Codependencies Dec 30, 2021
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor remark about the help text, otherwise looks very good, thanks!

Can you also add a news/7.feature file containing a short changelog paragraph (rst format) ? I use towncrier to generate the changelog.

"(the set of addons that depends on the set of selected addons).",
),
) -> None:
"""Print the co-dependencies of selected addons."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le's put the explanation about what a co-dependency is here rather than in the --include-selected description ?

@sbidoul
Copy link
Member

sbidoul commented Mar 28, 2022

Closes #7

@b-enoit-be
Copy link
Contributor

Any plans to merge it in a stable version yet?

I am exactly in the raised case of:

In most cases, to test a feature branch it is sufficient to test the modified modules and their co-dependencies.

that I would like to implement in our CI/CD

@len-foss
Copy link
Contributor Author

@b-enoit-be Unfortunately I have a big project deadline right now, so I don't think I'll have a look at it before one month from now. However I don't think there's much to fix to merge, so feel free to add what's missing.

@sbidoul sbidoul merged commit b6af383 into acsone:main May 12, 2022
@sbidoul
Copy link
Member

sbidoul commented May 12, 2022

Since I need to cut a release and this is almost finished, I merge and apply the last tweak in a followup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants