S3 in CI #201
Merged
S3 in CI #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlomnissan
reviewed
Jul 31, 2024
| run: | | ||
| tmux new -d -s minio | ||
| tmux send-keys -t minio "MINIO_ROOT_USER=$MINIO_ROOT_USER MINIO_ROOT_PASSWORD=$MINIO_ROOT_PASSWORD minio server /tmp/minio --console-address :9001" Enter | ||
| sleep 5 |
There was a problem hiding this comment.
Why is it necessary to put the terminal to sleep? Also, how did we decide on 5 seconds?
There was a problem hiding this comment.
We can take this part out for now, but we'll need to give the server some time to spin up before we start exercising it.
Edit: my bad, we are exercising the server already. 5 seconds is plenty of time to make sure the server is up before we start working it. We could maybe get away with fewer but if we go much lower we might see variance. We know 5 is good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
pull_requesttarget rather thanpull_request_targettarget and removes the automerge job.