This repository was archived by the owner on Nov 16, 2021. It is now read-only.
Support JavaScript libraries via Asset Packagist #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balsama
reviewed
Aug 14, 2017
composer.json
Outdated
| "drupal-composer/drupal-scaffold": "^2.0.0", | ||
| "cweagans/composer-patches": "^1.6.0", | ||
| "acquia/lightning": "~2.1.0" | ||
| "acquia/lightning": "~2.1.0", | ||
| "oomphinc/composer-installers-extender": "^1.1" |
There was a problem hiding this comment.
Is this necessary? Is it a root requirement? Thinking we can get rid of it altogether since it's in Lightning.
There was a problem hiding this comment.
We were directly requiring composer/installers before (which this supersedes), so as far as I can tell, it's a root requirement...we could open a follow-up PR to experiment with removing it, though.
There was a problem hiding this comment.
Agree. Let's fix it now though if we can. It changes the other PRs from four changes to two.
remove composer-installers(optional)Add composer-installers-extra- Add packagist
- Add new path definitions
added 3 commits
August 14, 2017 09:21
|
Perfect. If 1fa2071 passes, just change the lightning requirement back to ~2.1.6 and this is ready for merge. Also needs to be cherry picked to headless branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will partially unblock acquia/lightning#425 and allow us to bring in any JavaScript asset library using the asset-packagist.org Composer repo.