Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Ignore compiled theme CSS and other artifacts #978

Merged
merged 1 commit into from
Jan 19, 2017
Merged

Conversation

danepowell
Copy link
Contributor

Cog is about to remove their own .gitignore, and in general it seems that it's the responsibility of the parent project to ignore compiled CSS: https://github.com/acquia-pso/cog/issues/29

Once this and the Cog issue are merged, Cog-based themes should work out of the box with any BLT project (including deployment of CSS).

@geerlingguy
Copy link
Contributor

The only problem here is that there are some projects which want to compile everything and commit it to their repo, so we'll have the opposite problem. But, as long as they can customize their own .gitignore files, it might not be an issue.

@sarahjean
Copy link

@geerlingguy @danepowell Maybe a comment in there to that effect?

@grasmash grasmash added the Enhancement A feature or feature request label Jan 13, 2017
@danepowell
Copy link
Contributor Author

This is the same paradigm that we follow for all sorts of other build artifacts (contributed packages, front-end libraries, etc...) so I'm not sure it makes sense to document the exception inline here. I think it would be better to have separate documentation on how to commit source and build artifacts together (although I'm not sure why you'd want to use BLT at all in that case)

@geerlingguy
Copy link
Contributor

@danepowell - True... in one case we have a theme that used to use CSS and is now using SASS, but during the transitional period, to minimize weird issues, we're committing compiled CSS to the theme (until we get all the automation working correctly).

For any new projects (and as a general rule) there shouldn't be a need for an exception.

@geerlingguy
Copy link
Contributor

But it would be good to at least warn people strongly in the CHANGELOG/release notes for the next release, in case they're in the same situation I'm in for that particular site.

@danepowell
Copy link
Contributor Author

Definitely noting it in the release notes would be wise.

@grasmash grasmash merged commit 11d5867 into 8.x Jan 19, 2017
@grasmash grasmash deleted the danepowell-patch-2 branch February 15, 2017 02:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement A feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants