Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Set PHP memory limit for Travis. #947

Merged
merged 2 commits into from
Jan 25, 2017

Conversation

danepowell
Copy link
Contributor

We just had a deploy fail because update hooks that passed on Travis failed on ACE, due to memory exhaustion.

Right now Travis is using some default PHP memory limit, I think either 512M or 1024M. This sets it to 256M, which is what DrupalVM uses by default and is the upper limit of what you'd see on ACE.

@grasmash grasmash added in progress Enhancement A feature or feature request labels Jan 9, 2017
@grasmash
Copy link
Contributor

grasmash commented Jan 9, 2017

Hm. The notable difference is that we do things on Travis CI that we wouldn't do on ACE. E.g., we don't even composer install on ACE.

@danepowell
Copy link
Contributor Author

True, although I just tried this on a project and had no problem with the decreased memory limit. And consider that we run the same memory limit in DrupalVM every day and have no problem there.

You're probably right that it doesn't make sense for TravisCI to have a limit as low as ACE, but it should at least match the limit used by DrupalVM, which is what this PR does.

@grasmash
Copy link
Contributor

This won't ever cause a BLT build to fail, so let's add this to /.travis.yml too. That should provide a canary.

@danepowell
Copy link
Contributor Author

danepowell commented Jan 12, 2017

It looks like the memory was originally upped as part of #364 because the acsf:init task needed 1GB+ to run composer require drupal/acsf:~8. That seems a bit ridiculous, hopefully it was just a memory leak with an older version of composer.

If you want to be totally sure, I'd clear the Travis caches and then re-run the test on my latest commit.

@grasmash grasmash merged commit b551d84 into acquia:8.x Jan 25, 2017
@danepowell danepowell deleted the feature/travis-memory-limit branch December 6, 2017 00:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement A feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants