Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Remove factory-hooks from default template. #923

Merged
merged 1 commit into from
Jan 6, 2017

Conversation

dpagini
Copy link
Contributor

@dpagini dpagini commented Jan 6, 2017

Fixes #599.

Changes proposed:

  • Delete template/factory-hooks directory, as not all users of BLT are on Site Factory.
  • Move the hooks file to settings/acsf/.
    • This location could change if preferred. I originally was going to put these at scripts/acsf/ and move the one file manually, but then I opted to move an entire folder so that other settings files could be loaded in the future.
  • Create a new phing target acsf:init:hooks which creates the new folder, and prompts the user to add the folder to their repo.

All feedback is welcome!

@grasmash grasmash added the Enhancement A feature or feature request label Jan 6, 2017
@@ -20,4 +20,10 @@
<echo>An example alias file for ACSF is located in /drush/site-aliases/example.acsf.aliases.drushrc.php.</echo>
</target>

<target name="acsf:init:hooks">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a description and hidden="true". Thanks!

@dpagini
Copy link
Contributor Author

dpagini commented Jan 6, 2017

Added as requested.

@grasmash grasmash merged commit f645857 into acquia:8.x Jan 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement A feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants