Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Toggle modules per environment. #700

Merged
merged 1 commit into from
Nov 22, 2016
Merged

Conversation

danepowell
Copy link
Contributor

Fixes #668 .

Changes proposed:

  • Modules will be toggled based on the value of an "environment" parameter.
  • No functional change for the ci:setup, ci:update, local:setup, and local:update targets (we are simply consolidating variables)
  • For deploy:update, you will now need to define modules to toggle per environment. But if you prefer the old style, simply don't pass the environment parameter and it will default to deploy like before.

@danepowell
Copy link
Contributor Author

danepowell commented Nov 21, 2016

Note that at some point, we could take this even further and have an "environment" array that defines more than just modules per-environment. For example:

environment:
  local:
    modules:
      enable:
        - devel
      uninstall:
        - acquia_connector
    drush-alias: self
    uri: my-project.local // Use to set trusted_host pattern, base_url, etc
    caching: disabled // Use to enable/disable caching in a settings file
  dev:
    ...

We probably don't want to do all of that as part of this PR, but maybe we want to at least rename the array from "modules" to "environments"?

Copy link
Contributor

@grasmash grasmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about setting environment to dev in project.local.yml?

@danepowell
Copy link
Contributor Author

You could do that, it just seems like local is a distinct environment. For instance, you don't want shield locally, but you do want it on dev. And I think there's nice symmetry between the environments and ci:* and local:* wrappers.

At any rate, these are just suggested environments, projects can define whatever environments they want.

@grasmash grasmash merged commit 58a2b7d into acquia:8.x Nov 22, 2016
@danepowell danepowell deleted the feature/issue-668 branch December 6, 2017 00:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants