This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Allow precommit tasks to be defined in project.yml #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 29, 2016 10:01
Updates pre-commit hook to call a BLT task which will look for steps in the project.yml file.
The pre-commit command should prevent the commit if the tasks performed return errors. This can be overridden by using gits `--no-verify` option while committing.
|
Closing in favor of #692, which allows custom git hooks to be implemented. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates pre-commit hook to call a BLT task which will look for steps in the project.yml file. This will allow projects to define additional checks to enforce during the precommit stage.
Might need to change the key in
project.ymlfrom targets currently it will expect a list of targets as they are currently defined in BLT.With this change, I was a little cautious to allow properties to be passed around given the nature. As this means we will need to define a target for each entry point and document which targets get which parameters.