-
Notifications
You must be signed in to change notification settings - Fork 394
Feature: Multiple deployment targets/artifacts for different settings #47
Conversation
Note, this is NOT backwards compatible. |
|
||
<!-- Delete the existing deploy directory and re-initialize as an empty git repository. --> | ||
<phingcall target="deploy:artifact:prepare-dir"/> | ||
<!-- <phingcall target="deploy:artifact:prepare-dir"/> --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You commented out this target which makes /deploy. Since there is no directory, it cannot find it on line 55.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This then fails on /tests/phpunit/DeployTest.php
line 31,
$this->assertFileExists($this->deploy_dir);
|
||
<!-- Delete the existing deploy directory and re-initialize as an empty git repository. --> | ||
<phingcall target="deploy:artifact:prepare-dir"/> | ||
<phingcall target="deploy:artifact:prepare-dir"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have an extra space ;)
hosting: acsf | ||
gits: | ||
- [email protected]:bolt8.git | ||
- [email protected]:bolt8.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this one be removed? I don't see it above. [email protected]:bolt8.git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it as an example, Will change the file to be more example friendly.
name: Profserv ACSF | ||
|
||
myhosting: | ||
hosting: ace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rename the default remote default
and leave it uncommented. I would then comment out the ACSF part since that won't be very common.
You may also need to include, default_branch: master
since that was included in the other section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default_bracnh: master
didn't seem to be used at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if the default branch needs to be the same for all. It's what will be created when bolt is initialized and it's the branch that will be checked out I believe when the deploy artifacts are being made.
Used in line 130 of build.xml
in the create
task.
<exec command="git checkout -b ${git.default_branch}" dir="${bolt.new.dir}" logoutput="true" passthru="true" />
@kylebrowning, I think this looks good! |
@kylebrowning, with all the deployment PRs, I believe this is now out of date. |
Ill re-roll if we still want to do this. |
After a lot of messing about, we've decided to put this on the back burner. A few reasons:
In future, the follow format would likely be easiest to implement:
|
Allows for multiple deployment targets if wanted.