Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Feature: Multiple deployment targets/artifacts for different settings #47

Closed
wants to merge 13 commits into from
Closed

Feature: Multiple deployment targets/artifacts for different settings #47

wants to merge 13 commits into from

Conversation

kylebrowning
Copy link
Contributor

Allows for multiple deployment targets if wanted.

@kylebrowning
Copy link
Contributor Author

Note, this is NOT backwards compatible.


<!-- Delete the existing deploy directory and re-initialize as an empty git repository. -->
<phingcall target="deploy:artifact:prepare-dir"/>
<!-- <phingcall target="deploy:artifact:prepare-dir"/> -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You commented out this target which makes /deploy. Since there is no directory, it cannot find it on line 55.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This then fails on /tests/phpunit/DeployTest.php line 31,

$this->assertFileExists($this->deploy_dir);


<!-- Delete the existing deploy directory and re-initialize as an empty git repository. -->
<phingcall target="deploy:artifact:prepare-dir"/>
<phingcall target="deploy:artifact:prepare-dir"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have an extra space ;)

hosting: acsf
gits:
- [email protected]:bolt8.git
- [email protected]:bolt8.git
Copy link
Contributor

@damontgomery damontgomery May 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this one be removed? I don't see it above. [email protected]:bolt8.git

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it as an example, Will change the file to be more example friendly.

name: Profserv ACSF

myhosting:
hosting: ace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rename the default remote default and leave it uncommented. I would then comment out the ACSF part since that won't be very common.

You may also need to include, default_branch: master since that was included in the other section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default_bracnh: master didn't seem to be used at all.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if the default branch needs to be the same for all. It's what will be created when bolt is initialized and it's the branch that will be checked out I believe when the deploy artifacts are being made.

Used in line 130 of build.xml in the create task.

<exec command="git checkout -b ${git.default_branch}" dir="${bolt.new.dir}" logoutput="true" passthru="true" />

@damontgomery
Copy link
Contributor

@kylebrowning, I think this looks good!

@damontgomery
Copy link
Contributor

@kylebrowning, with all the deployment PRs, I believe this is now out of date.

@kylebrowning
Copy link
Contributor Author

Ill re-roll if we still want to do this.

@grasmash
Copy link
Contributor

After a lot of messing about, we've decided to put this on the back burner. A few reasons:

  1. The YAML formatting is unintuitive.
  2. The terminology of "ace" is a bit misleading since acp and acft would work with this setting as well.
  3. It's unclear that this is a feature that many people would use. If it comes up again, we can revisit.

In future, the follow format would likely be easiest to implement:

deploy.destinations:
  - ascf,[email protected]:bolt8.git
  - ace,[email protected]:bolt8.git

@grasmash grasmash closed this May 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants