This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Bugfix for ACSF db name. #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpagini
reviewed
Sep 20, 2016
| @@ -83,7 +83,7 @@ | |||
| /** | |||
| * Acquia Cloud settings. | |||
| */ | |||
| if ($is_ah_env && file_exists('/var/www/site-php')) { | |||
| if ($is_ah_env && file_exists('/var/www/site-php' && !$is_acsf)) { | |||
There was a problem hiding this comment.
This does work when deployed to ACSF, but your logic makes more sense
There was a problem hiding this comment.
I can submit a PR, just wanted to make sure it wasn't intentional. I assume this works on ACSF b/c the file_exists() command returns false (maybe?), but this would then not run correctly on ACE, I believe.
There was a problem hiding this comment.
Uh yeah I missed that. @dpagini I like the look of your suggestion better.
dpagini
added a commit
to dpagini/blt
that referenced
this pull request
Sep 20, 2016
Per a [discussion](acquia#418 (comment)) on PR#418, changing this IF statement a little. I think it makes sense to keep the secrets location on ACSF and ACE, as we do use this approach on ACE.
grasmash
pushed a commit
that referenced
this pull request
Sep 20, 2016
Per a [discussion](#418 (comment)) on PR#418, changing this IF statement a little. I think it makes sense to keep the secrets location on ACSF and ACE, as we do use this approach on ACE.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a very major ACSF issue where site-specific ACSF settings.inc template provided by the ACSF module are overridden in BLT - this caused ACSF sites in each environment to share a single, incorrect database and prevented the successful creation of new sites in some instances.