This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Update filesystem.settings.php for ACSF #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not 100% sure if this is the best way to address this. Previously, my project (as far as I could tell) was not setting "file_public_path", so I'm assuming it was set maybe through ACSF configuration? The latest release of BLT on L#8 sets the "file_public_path" to the default for all sites, even SF. To fix this, I had to explicitly set the file path after this file loads. Wondering if this change should be incorporated here upstream? Again, I'm not sure if this is the appropriate place for this, but this was my best guess.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure if this is the best way to address this. Previously, my project (as far as I could tell) was not setting "file_public_path", so I'm assuming it was set maybe through ACSF configuration? The latest release of BLT on L#8 sets the "file_public_path" to the default for all sites, even SF. To fix this, I had to explicitly set the file path after this file loads. Wondering if this change should be incorporated here upstream? Again, I'm not sure if this is the appropriate place for this, but this was my best guess.