This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Fixes #3734: DT-603: Errors during blt setup do not fail travis builds. #3756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danepowell
commented
Jul 17, 2019
| @@ -11,4 +11,4 @@ then | |||
| fi | |||
| fi | |||
|
|
|||
| set +v | |||
| set +ev | |||
There was a problem hiding this comment.
set +e is necessary at the end of each script to prevent that from bleeding into the parent script. If that happens, then travis_wait is terminated before it can print error output.
alexxed
approved these changes
Jul 18, 2019
adrianthedev
approved these changes
Jul 18, 2019
|
@mikemadison13 you can test this but I'm pretty sure it works and will merge after the next Lightning update (need to revert latest test-altering commit) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3734
Changes proposed
Just use
travis_waitinstead of our own proprietary tick-tock script, which apparently does not capture and replay exit codes.The tick-tock script was added in #2080, but there's no mention as to why it was used instead of travis_wait. Perhaps travis_wait didn't exist yet.