This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 394
Fixes #3511: Check Git user before committing, set dummy user if necessary #3541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danepowell
commented
Apr 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it, either, but the design seems good, and the implementation looks reasonable.
alexxed
reviewed
Apr 12, 2019
I refactored the Git commands into their own class, so we can set the author consistently for commits. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3511
Changes proposed
--author
argument to Git commits during deploys and new project creation.I haven't fully tested this yet, it very well might not work just yet. There's probably some opportunity to refactor the construction of the commit command. But I'd still appreciate any feedback.
@ba66e77 this is modifying a feature that you originally requested in #1323 , on the off chance that that is something precious to you. I think it should operate basically the same, except that we'll set the Git user on each commit rather than once for the whole repo.