Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Moves drush back [Do not merge until ACE 1.91 release] #34

Closed
wants to merge 1 commit into from
Closed

Moves drush back [Do not merge until ACE 1.91 release] #34

wants to merge 1 commit into from

Conversation

kylebrowning
Copy link
Contributor

@kylebrowning kylebrowning commented May 5, 2016

The issue here is that ACE has a block on using a vendor'ed drush.

Once ACE 1.91 goes out we can move this back for best practices.

(Unless its not a best practice anymore)

@grasmash
Copy link
Contributor

grasmash commented Jun 9, 2016

@kylebrowning Do you know if this can be merged now? I don't see mention of using vendored drush here: https://docs.acquia.com/node/24746

@kylebrowning
Copy link
Contributor Author

It's not deployed yet AFAICT. I'll check in the morning.

Sent from my iPhone

On Jun 8, 2016, at 9:42 PM, Matthew Grasmick [email protected] wrote:

@kylebrowning Do you know if this can be merged now? I don't see mention of using vendored drush here: https://docs.acquia.com/node/24746


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@danepowell
Copy link
Contributor

1.91 went to ACP yesterday but there is no ETA for an ACE release.

I don't think providing your own Drush was ever documented best practice, it was just the opinion of a few people (who probably all heard it from Moshe). Given how badly this failed in practice, I would vote to just close this PR and use the bin provided by ACE, unless we find a compelling reason to go back to providing our own.

@kylebrowning
Copy link
Contributor Author

Honestly I'm fine with closing this as well.

@grasmash grasmash closed this Jun 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants