Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

#249: Adding yaml parser to git-commit hook #250

Closed
wants to merge 2 commits into from

Conversation

msherron
Copy link
Contributor

@msherron msherron commented Aug 1, 2016

No description provided.

@grasmash
Copy link
Contributor

grasmash commented Aug 1, 2016

Looks like the contents of parse-yaml.sh might be wrong?

@msherron
Copy link
Contributor Author

msherron commented Aug 1, 2016

woops, updated :)

@grasmash
Copy link
Contributor

grasmash commented Aug 1, 2016

This seems like a great idea, but I'm hesitant to use bash string parsing to find this value. Adding a yaml:get command to drupal/console that leverages Symfony's yaml parser seems like a more reliable path forward, and it would be nice to make this more widely available--I've needed something like it before.

See https://github.com/hechoendrupal/DrupalConsole/tree/master/src/Command/Yaml

@grasmash
Copy link
Contributor

grasmash commented Aug 1, 2016

Pinging @jmolivas in case he has an opinion on adding something like yaml:get:value [key] [filename] to Drupal Console.

@grasmash
Copy link
Contributor

grasmash commented Aug 1, 2016

@grasmash
Copy link
Contributor

grasmash commented Aug 2, 2016

yaml:get:value [filename] [key] has been added to drupal console and released in beta5.

@grasmash
Copy link
Contributor

grasmash commented Aug 2, 2016

Closing in favor of #256

@grasmash grasmash closed this Aug 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants