This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Allow Drupal-VM config flexibility. #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate approach to 1754. If this goes in, this closes #1754.
Two main changes here...
vm.configas my config key as opposed toblt.config-files.drupal-vm. This alternate key feels like a more appropriate place to me after thevmkey was created in build.yml.vm:configcommand no longer prompts the user for an installation path for Drupal-VM, per request of @grasmash in 1754. The decision to use an alternate installation path for Drupal-VM becomes slightly more manual, but the flexibility still exists to move it, which is the key for me.Just FYI, I created this new PR as I'm referencing 1754.patch directly in my project, and this change in approach will require me to update my project.
Similar to comments in the other PR, the one thing I'm not 100% confident in the changes to
post-provision.shscript. I believe referencing the alias script directly at/vagrant/vendor/.../aliasworks as intended, I'm just not sure if there was reason this didn't work originally (maybe other OS or something?).