Added file path configuration. #179
Conversation
| $settings['file_private_path'] = "/mnt/gfs/$ah_group.$ah_env/files-private/$acsf_db_name"; | ||
| } | ||
| else { | ||
| $settings['file_private_path'] = "/mnt/files/$ah_group.$ah_env/files-private"; |
There was a problem hiding this comment.
I think this is another place where we should consider multisite. D7 version would look something like /mnt/files/' . $_ENV['AH_SITE_NAME'] . '/' . conf_path() . '/files-private', need to test the exact D8 syntax, but https://www.drupal.org/node/2275139 has some background since conf_path() is deprecated.
There was a problem hiding this comment.
We can use $site_path instead of $conf_path (the ACE settings files provide this variable.)
The bigger problem is how does files.settings.php know if we are a single-site or multisite install? We probably need a parameter in project.yml, as well as a way to propagate that variable into settings files. Or I guess we could just treat every site as multisite. I don't know if there's any harm in that.
There was a problem hiding this comment.
I think the latter is a safer assumption, but I do love being explicit.
There was a problem hiding this comment.
Or I guess we could just treat every site as multisite. I don't know if there's any harm in that.
I feel this is the right way to go.
If we can avoid using Acquia specific variables like $ah_group.$ah_env and use Drupal API functions like conf_path() instead this code will be a lot more portable and work on local, CI, as well as Acquia. We would still need to abstract the {path_to_docroot} piece at the beginning of these paths, though.
|
Closing in favor of #359. |
ACSF doesn't have any documentation on how to configure private files. This is the solution that Rok endorsed. The public documentation should be updated to reflect this soon.