This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Set site_dir to fix config imports on ACSF. #1635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLT sets the
$site_dir
variable in blt.settings.php and uses this variable in three places:/config/$site_dir
, usually/config/default
)The problem is that on ACSF, the site_dir is something like
g/files/abc1234
, because ACSF doesn't use true multisite. This is problematic because it prevents you from using a common configuration directory likeconfig/default
.This patch overrides this behavior to set the site_dir to
default
on ACSF.I could also see an argument for making the site_dir 'g', but this would make codebases less portable between ACE and ACSF (since you'd need to use a config directory like
/config/default
on ACE and/config/g
on ACSF).The only possible adverse effect I can see from this change is for sites that have legitimately separate configuration directories for all of their ACSF sites. But that just doesn't seem like it would be practical.