This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Ensure configuration export integrity #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danepowell
changed the title
danepowell
commented
Apr 21, 2017
| @@ -66,6 +66,13 @@ public function import() { | |||
| $task->exec("drush @$drush_alias pm-enable config_split --yes"); | |||
| $task->exec("drush @$drush_alias config-import sync --yes"); | |||
| } | |||
| if (!$this->getConfigValue('cm.allow-overrides')) { | |||
| $this->say("Checking for config overrides..."); | |||
| $config_overrides = $task->exec("drush @$drush_alias cex sync -n | grep 'Differences of the active config'"); | |||
There was a problem hiding this comment.
I don't think task output is captured quite the same as Phing, this will need some work
|
Should be good to go now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1414 for explanation
This is completely untested at the moment, since I don't have any projects running robo setup commands, and I'm not currently able to install and patch the 8.8.3 release (@grasmash see my email)