This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Fixes #1218: Update acsf-setup.md with subprofile guidance. #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grasmash
reviewed
Mar 30, 2017
readme/acsf-setup.md
Outdated
| 1. Create a custom module in `docroot/modules/custom` that will be used in lieu of a custom profile. | ||
| 1. Add `acsf` as a dependency for your custom module. | ||
| 1. If using lightning, create a custom [lightning.extend.yml](https://github.com/acquia/lightning/blob/8.x-1.x/lightning.extend.yml) and add it to `sites/default` | ||
| 1. Create a custom subprofile as described [here](https://docs.acquia.com/lightning/subprofile). |
There was a problem hiding this comment.
I think we need to cover both Lightning and non-Lightning use cases. For Lightning, use a sub profile. Otherwise create a new custom profile, which can easily be done with Drupal console.
grasmash
reviewed
Mar 30, 2017
readme/acsf-setup.md
Outdated
| 1. If using lightning, create a custom [lightning.extend.yml](https://github.com/acquia/lightning/blob/8.x-1.x/lightning.extend.yml) and add it to `sites/default` | ||
| 1. Create a custom subprofile as described [here](https://docs.acquia.com/lightning/subprofile). | ||
| 1. Add `acsf` as a dependency for your custom subprofile. | ||
| 1. Edit `blt/project.yml` to use the custom profile. |
There was a problem hiding this comment.
Let's specify which key needs to be changed by showing an example snippet.
grasmash
reviewed
Mar 30, 2017
readme/acsf-setup.md
Outdated
| 1. When creating a new site, select "Lightning" as the profile. | ||
| 1. When creating a new site, select your custom subprofile as the profile. | ||
|
|
||
| **Note:** Code can be deployed via cloud hooks and the above process will not work for updating existing ACSF sites using lightning. |
There was a problem hiding this comment.
I don't understand this note.
There was a problem hiding this comment.
Was trying to capture @lcatlett's comment. I guess I phrased it poorly. Not sure how you'd like to include that information
malikkotob
force-pushed
the
issue-1218-acsf-docs
branch
from
11adc62 to
91c9aaf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.