Fixes #915: Sync drushrc.php with template drushrc.php via update hook. #1265
Conversation
src/Update/Updater.php
Outdated
|
|
||
| if ($this->getFileSystem()->exists($sourcePath)) { | ||
| $this->getFileSystem()->copy($sourcePath, $targetPath, $overwrite); | ||
| if ($overwrite) { |
There was a problem hiding this comment.
If the file was copied but not overwritten, won't $fileCopied be FALSE?
There was a problem hiding this comment.
@grasmash that's true. Good catch. Looking back at the fileSystem copy method, I realized we actually don't have a way of knowing if the file actually copied if $overwrite is FALSE without us manually comparing the last modified date on the target file and the source file. I can either modify the logic to check that information (which feels a bit excessive) or I can simply not return anything - which is what the fileSystem copy method is currently doing (doesn't feel great either). Thoughts?
There was a problem hiding this comment.
Let's not return anything. An exception should be throw if it fails
malikkotob
force-pushed
the
drushrc-vendor
branch
from
2b16500 to
aa54bb7
Compare
malikkotob
force-pushed
the
drushrc-vendor
branch
from
aa54bb7 to
89ab92a
Compare
malikkotob
changed the title
No description provided.