Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Improve Git commit hooks #825

Closed
TravisCarden opened this issue Dec 20, 2016 · 3 comments
Closed

Improve Git commit hooks #825

TravisCarden opened this issue Dec 20, 2016 · 3 comments
Assignees
Labels
Enhancement A feature or feature request

Comments

@TravisCarden
Copy link
Contributor

Git hooks could use some improvement. Consider this output:

git-hook-output

That's a lot of visual noise. A couple ofthings stand out to me:

  1. Do I really need seven lines of Phing build info every time I commit? Can we either suppress some of that output or run phpcs directly? (Of all actions, I would like Git commits to be fast and lightweight.)
  2. The commit message error gets completely lost. It doesn't look like an error, because it neither says "error" nor uses color (e.g., red) to get my attention. I usually subconsciously filter it out the first two times I encounter it. Could we color it red and actually say "ERROR:"?
@grasmash grasmash added the Enhancement A feature or feature request label Dec 20, 2016
@grasmash
Copy link
Contributor

@TravisCarden What would your ideal output be in this scenario?

@grasmash
Copy link
Contributor

Also, what is your version of BLT?

@grasmash
Copy link
Contributor

I believe this has already been addressed. Current output is:

$ git commit -m 'Disabling lightning tests.'
Sniffing staged files via PHP Code Sniffer...
Linting custom twig files...
Validating composer.json...
Ok!
[blt-update a64b4b228] Disabling lightning tests.
 1 file changed, 3 insertions(+), 1 deletion(-)

grasmash added a commit to grasmash/bolt that referenced this issue Dec 21, 2016
@grasmash grasmash self-assigned this Dec 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement A feature or feature request
Projects
None yet
Development

No branches or pull requests

2 participants