Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

"vendor/acquia/blt/composer.suggested.json" causing issues with composer #1325

Closed
arknoll opened this issue Apr 6, 2017 · 8 comments
Closed

"vendor/acquia/blt/composer.suggested.json" causing issues with composer #1325

arknoll opened this issue Apr 6, 2017 · 8 comments
Labels
Bug Something isn't working

Comments

@arknoll
Copy link
Contributor

arknoll commented Apr 6, 2017

My system information:

  • Operating system type: OSX
  • Operating system version: Sierra
  • BLT version: 8.7.1

When I am updating lightning like this:

composer require acquia/lightning:^2.1.0
rm -rf vendor && composer install

I got all the correct updated dependencies.
Then I ran:

composer update

and it downgraded me to older versions. For instance:

Updating drupal/core (8.3.0 => 8.2.7) Loading from cache

Then I ran:

composer update

again. And nothing was updated.
Then I removed from my composer.json:

"vendor/acquia/blt/composer.suggested.json"

And ran composer update and I got all the correct dependencies again.

Need to figure out why the suggested json is causing this problem.
@kylebrowning
Copy link
Contributor

Same here

@arknoll arknoll mentioned this issue Apr 6, 2017
Closed
@arknoll
Copy link
Contributor Author

arknoll commented Apr 6, 2017

More info:
If I leave "vendor/acquia/blt/composer.suggested.json" in and add

{
  "require": {
    "acquia/lightning": "2.1.0",
    "drupal/search_api": "1.0-beta5"
  }
}

to blt/composer.overrides.json and run composer update, it still doesn't work.

@grasmash
Copy link
Contributor

grasmash commented Apr 6, 2017

This seems like one of the packages in composer.suggested.json needs to be changed. Are you sure that the Lightning version is what is causing the problem?

@arknoll
Copy link
Contributor Author

arknoll commented Apr 6, 2017

This is what has worked for me:

  • Removed "vendor/acquia/blt/composer.suggested.json" from composer file
  • Added to composer file:
    "require": {
        "drupal/acquia_connector": "^1.5.0",
        "drupal/cog": "^1.0.0",
        "drupal/memcache": "2.x-dev",
        "drupal/seckit": "^1.0.0-alpha2",
        "drupal/security_review": "*",
        "drupal/shield": "^1.0.0"
     },
     "extra": {
        "patches": {
           "drupal/memcache": {
              "SASL Support in Drupal 8 version": "https://www.drupal.org/files/issues/sasl_drupal_8-2862230-3.patch"
            }
         },

@grasmash grasmash added the Support A support request label Apr 6, 2017
grasmash added a commit to grasmash/bolt that referenced this issue Apr 6, 2017
@grasmash
Fixes acquia#1325: Make composer.overrides.json work properly.
5ddb22a
@grasmash
Copy link
Contributor

grasmash commented Apr 6, 2017

Best solution is to get this merged: wikimedia/composer-merge-plugin#142

@grasmash grasmash added Bug Something isn't working and removed Support A support request labels Apr 6, 2017
@grasmash grasmash changed the title "vendor/acquia/blt/composer.suggested.json" causing issues with composer "vendor/acquia/blt/composer.suggested.json" causing issues with composer Apr 7, 2017
@justclint justclint mentioned this issue Apr 14, 2017
Closed
@justinlevi
Copy link
Contributor

justinlevi commented Apr 14, 2017 •
edited
Loading

yeah, I just ran into this issue as well and kept getting the following error until I merged composer.suggested.json into the root composer.json file.

  [Exception]                                                                                                               
  Cannot apply patch SASL Support in Drupal 8 version (https://www.drupal.org/files/issues/sasl_drupal_8-2862230-3.patch)!

Here's my composer.json file for reference:

{
    "name": "acquia/blt-project",
    "description": "Project template for Drupal 8 sites built with BLT.",
    "type": "project",
    "minimum-stability": "dev",
    "prefer-stable": true,
    "require": {
        "acquia/lightning": "^2.0.3",
        "drupal/acquia_connector": "^1.5.0",
        "drupal/cog": "^1.0.0",
        "drupal/qa_accounts": "^1.0.0-alpha1",
        "drupal/memcache": "2.x-dev",
        "drupal/seckit": "^1.0.0-alpha2",
        "drupal/security_review": "*",
        "drupal/shield": "^1.0.0",
        "acquia/blt": "^8.8.0",
        "composer/installers": "^1.0",
        "drupal/adminimal_theme": "^1.3",
        "drupal/core": "^8.3.0",
        "drupal/jsonapi": "^1.0@beta",
        "drupal/redirect": "1.0-alpha1",
        "burdamagazinorg/thunder": "^8.1",
        "enyo/dropzone": "4.2.0",
        "cweagans/composer-patches": "1.6.1",
        "drupal/access_unpublished": "^1.0",
        "drupal/adsense": "^1.0",
        "drupal/admin_toolbar": "^1.0",
        "drupal/better_normalizers": "1.0-beta2",
        "drupal/blazy": "1.0-rc1",
        "drupal/breakpoint_js_settings": "^1.0",
        "drupal/checklistapi": "^1.0",
        "drupal/config_update": "^1.0",
        "drupal/crop": "^1.0",
        "drupal/ctools": "^3.0",
        "drupal/default_content": "^1.0",
        "drupal/diff": "^1.0",
        "drupal/dropzonejs": "^1.0",
        "drupal/entity": "^1.0",
        "drupal/entity_browser": "^1.0",
        "drupal/entity_reference_revisions": "1.2",
        "drupal/field_group": "^1.0",
        "drupal/focal_point": "^1.0",
        "drupal/google_analytics": "^2.0",
        "drupal/inline_entity_form": "^1.0",
        "drupal/libraries": "dev-3.x",
        "drupal/linkit": "^4.0",
        "drupal/media_entity": "1.6",
        "drupal/media_entity_instagram": "1.2",
        "drupal/media_entity_image": "dev-1.x",
        "drupal/media_entity_slideshow": "^1.0",
        "drupal/media_entity_twitter": "^1.0",
        "drupal/metatag": "^1.0",
        "drupal/paragraphs": "^1.0",
        "drupal/pathauto": "^1.0",
        "drupal/responsive_preview": "^1.0",
        "drupal/scheduler": "^1.0",
        "drupal/simple_sitemap": "^2.0",
        "drupal/thunder_admin": "dev-1.x",
        "drupal/token": "^1.0",
        "drupal/video_embed_field": "^1.0",
        "drupal/views_load_more": "dev-1.x",
        "drupal/memcache": "2.x-dev",
        "drupal/media_entity_document": "^1.1"
    },
    "provide": {
        "heiseonline/shariff": "master"
    },
    "require-dev": {
        "geerlingguy/drupal-vm": "~4.3"
    },
    "scripts": {
        "blt-alias": "blt install-alias -Dcreate_alias=true",
        "drupal-scaffold": "DrupalComposer\\DrupalScaffold\\Plugin::scaffold"
    },
    "repositories": {
        "drupal": {
            "type": "composer",
            "url": "https://packages.drupal.org/8"
        },
        "drupal-library": {
            "type": "package",
            "package": {
                "name": "enyo/dropzone",
                "version": "4.2.0",
                "type": "drupal-library",
                "source": {
                    "url": "https://github.com/enyo/dropzone",
                    "type": "git",
                    "reference": "origin/master"
                }
            }
        }
    },
    "extra": {
        "enable-patching": true,
        "installer-paths": {
            "docroot/core": [
                "type:drupal-core"
            ],
            "docroot/modules/contrib/{$name}": [
                "type:drupal-module"
            ],
            "docroot/modules/custom/{$name}": [
                "type:drupal-custom-module"
            ],
            "docroot/profiles/contrib/{$name}": [
                "type:drupal-profile"
            ],
            "docroot/profiles/custom/{$name}": [
                "type:drupal-custom-profile"
            ],
            "docroot/themes/contrib/{$name}": [
                "type:drupal-theme"
            ],
            "docroot/themes/custom/{$name}": [
                "type:drupal-custom-theme"
            ],
            "docroot/libraries/{$name}": [
                "type:drupal-library"
            ],
            "drush/contrib/{$name}": [
                "type:drupal-drush"
            ]
        },
        "merge-plugin": {
            "require": [
                "vendor/acquia/blt/composer.required.json"
            ],
            "include": [
                "blt/composer.overrides.json"
            ],
            "merge-extra": true,
            "merge-extra-deep": true,
            "merge-scripts": true,
            "replace": true
        },
        "patches": {
            "drupal/core": {
                "Image check for the presence of the array before using it in a function call": "https://www.drupal.org/files/issues/2745491-15.patch",
                "Ignore front end vendor folders to improve directory search performance": "https://www.drupal.org/files/issues/ignore_front_end_vendor-2329453-116.patch",
                "Turn Views exposed filters for dates into date fields": "https://www.drupal.org/files/issues/views_exposed_filter-2710793-8.patch"
            },
            "drupal/adminimal_theme": {
                "Incompatible with admin toolbar": "https://www.drupal.org/files/issues/incompatible_with_admin-2635456-4_0.patch"
            },
            "drupal/dropzonejs": {
                "Add missing EB widget schema": "https://www.drupal.org/files/issues/add_missing_eb_widget-2813143-2.patch"
            },
            "drupal/linked_field": {
                "Fix breaking of picture markup": "https://www.drupal.org/files/issues/linked_field_breaks-2319165-7.patch"
            },
            "drupal/media_entity": {
                "class Media extends ContentEntityBase implements MediaInterface": "https://www.drupal.org/files/issues/2749695_14_media_entity.patch"
            },
            "drupal/media_entity_image": {
                "class Image extends MediaTypeBase": "https://www.drupal.org/files/issues/2749695_14_media_entity_image.patch"
            },
            "drupal/diff": {
                "Back button for comparison page": "https://www.drupal.org/files/issues/back_button_for-2853193-4.patch"
            },
            "drupal/memcache": {
                "SASL Support in Drupal 8 version": "https://www.drupal.org/files/issues/sasl_drupal_8-2862230-3.patch"
            }
        }
    }
}

@grasmash
Copy link
Contributor

@justinlevi that is due to #1380, which was resolved in 8.8.2.

@grasmash
Copy link
Contributor

Resolved by #1430

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kylebrowning @grasmash @justinlevi @arknoll