Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

PHPUnit Git tests shouldn't create actual commits #11

Closed
danepowell opened this issue May 2, 2016 · 1 comment
Closed

PHPUnit Git tests shouldn't create actual commits #11

danepowell opened this issue May 2, 2016 · 1 comment
Assignees

Comments

@danepowell
Copy link
Contributor

Right now the Git tests attempt to create real live Git commits: https://github.com/acquia/bolt/blob/8.x/template/tests/phpunit/GitTest.php

This means that if you run unit tests on a local machine, you're unknowingly left with a contaminated Git history.

I'm not sure I see the value in running these tests at all on a continuous basis in a deployed Bolt installation... they seem more valuable for testing the initial Bolt setup. Assuming we need to keep them, think about using --dry-run or some other process to avoid creating permanent commits.

grasmash added a commit to grasmash/bolt that referenced this issue May 5, 2016
@grasmash grasmash self-assigned this May 5, 2016
grasmash added a commit to grasmash/bolt that referenced this issue May 5, 2016
@grasmash
Copy link
Contributor

grasmash commented Aug 3, 2016

This has been resolved (as best I could) by resetting HEAD after a commit has been made.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants