STAR-110 Remove all IDs from SVG files #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was looking for automated solution. But found only this issue: svg/svgo#563 The only option for now - remove redundant |
DanilAgafonov
commented
Jan 24, 2020
| @@ -14,7 +14,7 @@ | |||
| "access": "public" | |||
| }, | |||
| "scripts": { | |||
| "svgr": "npx @svgr/cli -d . src/svg --out-dir src/" | |||
| "svgr": "svgr -d . src/svg --out-dir src/" | |||
There was a problem hiding this comment.
The reason of this change: npx use latest version of @svgr/cli from npmjs.com. It means that version lock ("@svgr/cli": "^4.1.0") will be ignored. After this change Yarn will run ./node_modules/.bin/svgr.
alexzherdev
approved these changes
Jan 24, 2020
|
@DanilAgafonov: PR ready in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose 🚀
If we insert any icon to page more than one time, then we get ID collision. This PR eliminates this issue.
Updates 📦
@paprika/iconStorybook 📕
http://storybooks.highbond-s3.com/paprika/STAR-110-duplicate-svg-ids
References 🔗
https://aclgrc.atlassian.net/browse/STAR-110