-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] EEG-BIDS Events replace Annotations; plus adding HED Support #1041
Merged
cmadjar
merged 20 commits into
aces:main
from
jeffersoncasimir:2024_01_29_events_replace_annotations
Mar 27, 2024
Merged
[python] EEG-BIDS Events replace Annotations; plus adding HED Support #1041
cmadjar
merged 20 commits into
aces:main
from
jeffersoncasimir:2024_01_29_events_replace_annotations
Mar 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 31, 2024
let's change pr title to |
@jeffersoncasimir who would best the best person to review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-BIDS
Area: BIDS. Issues and pull requests related to BIDS and the BIDS import pipeline
A-EEG
Area: EEG. Issues and pull requests related to EEG / iEEG processing
Add to release notes
Caveat for Existing Projects
Priority: High
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has multiple Loris counterparts:
Events to Annotations: #9032
HED support: #9033
It aims to make the Python pipeline more compliant with the current BIDS standard.
It does so by replacing references of
annotations
files and terms with references toevents
files and terms.It also brings in support for ingesting dataset-level (from dataset-level
events.json
) and instance-level (HED
column inevents.tsv
) HED Tags.Current HED limitations:
events.json
It also does some file name refactoring in the
database_lib
folder to standardize the name structure.Some logic was also moved to new
database_lib
files.MAKE SURE YOU PATCH SQL + ADD BOTH SCHEMAS WITH THE
insert_hed_schema.php
TOOL IN ACES/LORIS PRS FIRST