Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/custom token validation #52

Merged

Conversation

dotansimha
Copy link
Member

@dotansimha dotansimha commented Feb 5, 2017

Added feature that allows developer to set custom resumeSessionValidator using the Accounts.config.
The method is called as async method, and should resolve without throw - otherwise the error is used as AccountsError.
If the Promise returned from the method is valid - the resumeSession will return correctly with the user.

Also, added unit tests and fixed all lint errors.

Copy link
Member

@TimMikeladze TimMikeladze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@TimMikeladze TimMikeladze merged commit 9f0439b into accounts-js:master Feb 5, 2017
@dotansimha dotansimha deleted the feature/custom-token-validation branch February 5, 2017 19:32
Aetherall pushed a commit that referenced this pull request Mar 11, 2018
Update dependency @accounts/server to v0.1.0-beta.2
Aetherall pushed a commit that referenced this pull request Mar 13, 2018
Update dependency @accounts/server to v0.1.0-beta.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants