Verify email #47
Verify email #47
Conversation
| @@ -12,6 +12,7 @@ export interface DBInterface { | |||
| findUserByEmail(email: string) : Promise<?UserObjectType>, | |||
| findUserByUsername(username: string) : Promise<?UserObjectType>, | |||
| findUserById(userId: string) : Promise<?UserObjectType>, | |||
| findUserByEmailVerificationToken(token: string) : Promise<?UserObjectType>, | |||
There was a problem hiding this comment.
Not sure about the name of the function
packages/server/src/tokens.js
Outdated
| @@ -1,5 +1,8 @@ | |||
| // @flow | |||
| import jwt from 'jsonwebtoken'; | |||
| import crypto from 'crypto'; | |||
|
|
|||
| export const generateToken = (length: Int = 43) => crypto.randomBytes(length).toString('hex'); | |||
There was a problem hiding this comment.
Is it a good place for this function?
There was a problem hiding this comment.
Good place. I'd call it generateEmailToken.
| message: 'Verify email link expired', | ||
| }); | ||
| } | ||
| const tokenRecord = find(user.services.email.verificationTokens, |
There was a problem hiding this comment.
@TimMikeladze will all dbInterfaces return the user object formatted in the same way ?
| message: 'Verify email link expired', | ||
| }); | ||
| } | ||
| const tokenRecord = find(user.services.email.verificationTokens, |
There was a problem hiding this comment.
Need to add services to the UserObjectType
| message: 'Verify email link expired', | ||
| }); | ||
| } | ||
| const emailRecord = find(user.emails, (e: Object) => e.address === tokenRecord.address); |
There was a problem hiding this comment.
Need to make another modification to the UserObjecType and the places it is returned at, since it has a string email key. Perhaps this could be an explicit call to a this.findEmailByToken function?
There was a problem hiding this comment.
I think it will be the only place we will need this function, I don't think it's necessary to make a special function.
| message: 'Verify email link expired', | ||
| }); | ||
| } | ||
| const tokenRecord = find(user.services.email.verificationTokens, |
packages/server/src/tokens.js
Outdated
| @@ -1,5 +1,8 @@ | |||
| // @flow | |||
| import jwt from 'jsonwebtoken'; | |||
| import crypto from 'crypto'; | |||
|
|
|||
| export const generateToken = (length: Int = 43) => crypto.randomBytes(length).toString('hex'); | |||
There was a problem hiding this comment.
Good place. I'd call it generateEmailToken.
Update dependency mongodb to ^3.0.0
Update dependency mongodb to ^3.0.0
No description provided.