Sessions and user info #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradel
reviewed
Jan 31, 2017
| } | ||
| } | ||
| async resumeSession(accessToken: string): Promise<UserObjectType> { | ||
| const session : UserObjectType = await this.findSessionByAccessToken(accessToken); |
There was a problem hiding this comment.
SessionType instead of SessionType
| }); | ||
| } | ||
| } | ||
| async resumeSession(accessToken: string): Promise<UserObjectType> { |
There was a problem hiding this comment.
?UserObjectType could return null
| }); | ||
| } | ||
| await this.db.invalidateSession(session.sessionId); | ||
| } else { // eslint-disable-line no-else-return |
There was a problem hiding this comment.
Should we delete the invalid session if it's not longer valid ?
There was a problem hiding this comment.
I think the lifespan of expired sessions should be configurable. It can provide a useful log for user account activity. Keep the latest 10 sessions for example.
There was a problem hiding this comment.
I'll create an issue for this.
|
@pradel Updated. |
pradel
approved these changes
Jan 31, 2017
|
Thanks! |
Aetherall
pushed a commit
that referenced
this pull request
Mar 11, 2018
Update dependency @types/jest to v22
Aetherall
pushed a commit
that referenced
this pull request
Mar 13, 2018
Update dependency @types/jest to v22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a variety of improvements to the user session code and also adds support for user profiles.