Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable prefix to avoid local storage key collisions on the same domain #35

Merged
merged 1 commit into from
Jan 18, 2017

Conversation

TimMikeladze
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 85.6% when pulling 9bb76c9 on devel into 20b1663 on master.

Copy link

@alexyuly alexyuly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Looks like this is the bug you mentioned this morning.

@TimMikeladze
Copy link
Member Author

That's right. I was thinking it was gonna be harder to solve then it turned out to be, but it was a real "wtf" moment at first.

@TimMikeladze TimMikeladze merged commit c1e1571 into master Jan 18, 2017
Aetherall pushed a commit that referenced this pull request Mar 11, 2018
Aetherall pushed a commit that referenced this pull request Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants