Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP : Auth - Transport - TransportStorage #223

Closed
wants to merge 9 commits into from
Closed

Conversation

Aetherall
Copy link
Member

@Aetherall Aetherall commented Apr 3, 2018

I'm about to make big changes to the project that will not be compatible with current packages

These changes will make the client incompatible with the server, and therefore I will have to re-create it

That's why I created this branch, in order to be able to follow the progression of the commits without breaking the v0.1

This branch will be merged to smaller PRs.

You can find more informations in #195 and #181

AccountsServer

TransportExpress

PasswordService & AuthService

Token Transport

Global

Misc

  • Allow user overriding in createUser

Steps:


  • TokenizedUrl

@codecov-io
Copy link

codecov-io commented Apr 3, 2018

Codecov Report

Merging #223 into master will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #223      +/-   ##
========================================
+ Coverage   93.74%    94%   +0.26%     
========================================
  Files          56     56              
  Lines        1343   1335       -8     
  Branches      188    191       +3     
========================================
- Hits         1259   1255       -4     
+ Misses         76     74       -2     
+ Partials        8      6       -2
Impacted Files Coverage Δ
packages/server/src/index.ts 100% <ø> (ø) ⬆️
packages/token-manager/src/token-manager.ts 100% <100%> (ø)
packages/server/src/accounts-server.ts 90.96% <100%> (+1.45%) ⬆️
packages/token-manager/src/index.ts 100% <100%> (ø)
packages/password/src/accounts-password.ts 93.37% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d287a...7542144. Read the comment docs.

@TimMikeladze
Copy link
Member

Closing this PR, will be updated and resubmitted in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants