Automatically adding user to graphql resolver context

[elie222]

I see the code has authenticated as shown here:

changePassword: authenticated(accountsServer, changePassword(accountsServer)),

Would it make sense to just add authenticated to the context and have the user object available for every request made to the server?

Right now I have this in my code:

const server = new ApolloServer({
  typeDefs: [typeDefs as any, accountsGraphQL.typeDefs],
  resolvers: merge(accountsGraphQL.resolvers, resolvers),
  context: async ({ req }) => {
    const ctx = accountsContext(req)
    const { authToken } = ctx

    let user

    try {
      user = await accountsServer.resumeSession(authToken as string)
    } catch (error) {}

    return {
      ...ctx,
      user,
      userId: user && user._id,
    }
  },
})

Seems something like this would be useful for all users of the graphql-api package. Would it make sense to have accountsContext also return the user object if it exists.

[TimMikeladze]

This sounds like a good improvement to me.

[elie222]

Is resume session as in the code above the best way to do this?

[TimMikeladze]

I think so. After this change do you think the getUser query is still needed? Or perhaps it could be modified to return context.user if it exists?

[elie222]

I'm not sure I follow why it wouldn't be needed. If the client wants to get information about the current user, getuser would still be the way to do it, no?

…

On Wed, 1 Aug 2018, 21:01 Tim Mikeladze, ***@***.***> wrote: I think so. After this change do you think the getUser query is still needed? Or perhaps it could be modified to return context.user if it exists? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#421 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC8oX42gJ3gl0qb3Y_zB3Z1rQRIof3wtks5uMezxgaJpZM4Vm55g> .

[TimMikeladze]

Yeah sorry I worded that incorrectly. I meant to say that it should be modified to use context.user if it exists instead of doing Accounts.resumeSession.

[pradel]

@elie222 was wondering does throwing inside the context function create a formatted graphql error?

[lorensr]

AFAICT, the current behavior is that whenever there's a valid access token stored on the client, it's included in a header, and accountsContext() provides a context.user object to all of my resolvers.

[elie222]

Are you sure about that? Will need to check again. I had to add that functionality myself because I didn't see it already included. I just the ip and access token sent on with no user object.

…

On Sat, 4 Aug 2018, 06:15 Loren ☺️, ***@***.***> wrote: AFAICT, the current behavior is that whenever there's a valid access token stored on the client, it's included in a header, and accountsContext() provides a context.user object to all of my resolvers. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#421 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC8oXw7PyyjtF5BLavX9xnDlq6fcH989ks5uNRHsgaJpZM4Vm55g> .

[pradel]

I just submitted a pull request for that #437