-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mock net and dns modules if running in browser #32
Comments
I've looked into it and we might want to setup lerna for the accounts package only. What do you think? |
Fine by me. But I don't see how this will fix the problem unless the solution ends up being to split this repo up into a client and server repo? From my understanding lerna just helps in the management of a project with multiple packages. |
The repo will stay a mono repo but lerna will create at least two packages on npm. I think actually we need three packages: core, server and client. |
This will be resolved by #33 |
@davidyaha per our discussion in slack
The https://github.com/auth0/node-jsonwebtoken package has dependencies on the net and dns modules which aren't available on the client. This presents a problem since this is a repo publishing both client and server code in a single package.
Currently the work around is to mock them in the consuming app's webpack config as seen below.
The simple solution is to provide these mocks within the core accounts package if running on the browser.
The text was updated successfully, but these errors were encountered: