-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite / Improve error handling #31
Labels
Comments
@davidyaha Maybe you could tackle this issue? |
On vacation till Monday but I'll take a look when I get back. Rest-example is currently working? |
Yep, on the |
Nice! Have fun! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the
apollo-errors
package is being consumed by our customAccountsError
class to throw errors. Moving forward we can continue usingapollo-errors
or make our own custom error class. The reason behind usingapollo-errors
is that it allows errors to carry more data than just an error message, this is particularly useful in the case of validation errors where you want to associate errors with certain fields. Furthermore this allows http status codes to be sent along side the message, rather than within it.The other packages that consume
@accounts/accounts
:rest-api
,rest
,react
and the db interfaces will also need their error handling code to be updated as part of this issue.The text was updated successfully, but these errors were encountered: