Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite / Improve error handling #31

Closed
TimMikeladze opened this issue Jan 14, 2017 · 4 comments
Closed

Rewrite / Improve error handling #31

TimMikeladze opened this issue Jan 14, 2017 · 4 comments

Comments

@TimMikeladze
Copy link
Member

TimMikeladze commented Jan 14, 2017

Currently the apollo-errors package is being consumed by our custom AccountsError class to throw errors. Moving forward we can continue using apollo-errors or make our own custom error class. The reason behind using apollo-errors is that it allows errors to carry more data than just an error message, this is particularly useful in the case of validation errors where you want to associate errors with certain fields. Furthermore this allows http status codes to be sent along side the message, rather than within it.

The other packages that consume @accounts/accounts: rest-api, rest, react and the db interfaces will also need their error handling code to be updated as part of this issue.

@TimMikeladze
Copy link
Member Author

@davidyaha Maybe you could tackle this issue?

@davidyaha
Copy link
Member

On vacation till Monday but I'll take a look when I get back. Rest-example is currently working?

@TimMikeladze
Copy link
Member Author

TimMikeladze commented Jan 14, 2017

Yep, on the devel branch with redis as the data store. It's working, will be working even better by Monday 😜 , dedicating the entire weekend to this. Thanks!

@davidyaha
Copy link
Member

Nice! Have fun!

@davidyaha davidyaha self-assigned this Jan 24, 2017
Aetherall pushed a commit that referenced this issue Mar 11, 2018
Aetherall pushed a commit that referenced this issue Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants