Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing system #21

Closed
TimMikeladze opened this issue Dec 13, 2016 · 1 comment
Closed

Typing system #21

TimMikeladze opened this issue Dec 13, 2016 · 1 comment
Labels
enhancement help wanted

Comments

@TimMikeladze
Copy link
Member

Per discussion with @davidyaha, this set of packages could benefit from a typing system since we're defining interfaces for communication between packages.

Flow and Typescript are the two options. I like Flow in favor of Typescript because of the minimal buy in, you can continue using the current build setup which is more familiar for JS developers not familiar with Typescript. On the other hand, Typescript has been gaining a considerable amount of adoption in the community but does have a more involved configuration.
@davidyaha
Copy link
Member

Started working on the GraphQL transport with flow. If there is strong objection to it, let us know.

@TimMikeladze TimMikeladze mentioned this issue Dec 15, 2016
Closed
Aetherall pushed a commit that referenced this issue Mar 11, 2018
@davidyaha @Aetherall
Merge pull request #21 from js-accounts/set-reset-password
2b0e776 
Implemented setResetPassword method
Aetherall pushed a commit that referenced this issue Mar 13, 2018
@davidyaha @Aetherall
Merge pull request #21 from js-accounts/set-reset-password
727f6e3 
Implemented setResetPassword method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TimMikeladze @davidyaha