-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pdf) : load/save CiceroMark and templates to PDF #351
Conversation
Signed-off-by: Dan Selman <[email protected]>
@jeromesimeon for review and discussion. This gets us a step closer to being able to exchange CiceroMark + templates. It uses the PDF as the carrier in this case. |
Signed-off-by: Dan Selman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TemplateMark + Data => CiceroMark : Use case 1, allows someone to see the values of the data, and regenerate the natural language Execution would require Cicero Template : Use case 2, allows someone to simulate or process transactions
|
@dselman Can we get a status report on this tomorrow? I'm unclear what proposal went in and if we need to open an issue about this (was there ever one?). |
Most specifically was this proposal implemented? |
Sure. The merged code allows the caller to optionally pass an array of templates that are stored in the PDF (off by default). |
Signed-off-by: Dan Selman [email protected]
Changes
Viewing PDF metadata inside Acrobat
roundtrip.md.pdf
PDF with embedded CiceroMark and Acceptance of Delivery template
Flags
templates
to org.accordproject.commonmark.Document?Related Issues