no_vnc_heartbeat param to enable ws ping/pong #24
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @patlachance I'll merge your PR and my changes from the next_release branch after I'll get your answer about the testing results (see the issue #23). I really appreciate that you've thought even about the readme file. Thanks. Regards |
accetto
approved these changes
Apr 29, 2022
Comment on lines
+156
to
+157
| If your session disconnnects, it might be related to a network equipment (load-balancer, reverse proxy, ...) dropping the websocket session for inactivity (more info [here](https://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_read_timeout) and [here](https://nginx.org/en/docs/http/websocket.html) for nginx). In such case, try defining the NO_VNC_HEARTBEAT=<xx environment variable at startup-time, where <xx> is the number of seconds between each [websocket ping/pong](https://github.com/websockets/ws/issues/977) packet. | ||
|
|
Comment on lines
+97
to
+102
| if [ -n "${NO_VNC_HEARTBEAT}" ]; then | ||
| HEARTBEAT_OPT="--heartbeat ${NO_VNC_HEARTBEAT}" | ||
| fi | ||
|
|
||
| ### noVNC startup (in the background) | ||
| "${NO_VNC_HOME}"/utils/novnc_proxy --vnc localhost:${VNC_PORT} --listen ${NO_VNC_PORT} &> "${_novnc_log}" & | ||
| "${NO_VNC_HOME}"/utils/novnc_proxy --vnc localhost:${VNC_PORT} --listen ${NO_VNC_PORT} ${HEARTBEAT_OPT} &> "${_novnc_log}" & |
There was a problem hiding this comment.
These changes are OK, but I've added some more stuff in a meantime, so I'll overwrite them later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #23.