Compatability for php8.1 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thank you. I'll get on this. |
Merged
|
I've made a pre-release tagged here: https://github.com/academe/SagePay-Integration/releases/tag/2.1.0 If you would like to give it a try, then let me know how it goes so I can take this release further. I've added a number of other little fixes highlighted by PHP Stan, but not personally run the code yet against Opayo servers. |
|
Thanks. The diff from 2.0.3 only shows the changes I added which work fine. 2.0.3...2.1.0 |
|
Not sure what happened there. I probably committed your main changes to the new branch, then forgot to commit my additionation changes. New release at https://github.com/academe/SagePay-Integration/releases/tag/2.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#[\ReturnTypeWillChange]to jsonSerialize to suppress notice ofPHP Deprecated: Return type of Academe\SagePay\Psr7\Request\Model\Address::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice