Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] PayDirekt: Add purpose parameter #11

Merged
merged 1 commit into from
Aug 4, 2018
Merged

[BUGFIX] PayDirekt: Add purpose parameter #11

merged 1 commit into from
Aug 4, 2018

Conversation

thommyhh
Copy link
Collaborator

@thommyhh thommyhh commented Aug 3, 2018

No description provided.

@judgej
Copy link
Member

judgej commented Aug 4, 2018

Thank you. So I understand correctly (and after trying it out on the sandbox), a capture of a PayDirekt authorisation requires the purpose field, which is derived from the description parameter in Omnipay. Without that field being present - whether empty or not (empty is permitted) the gateway will fail to cpature with error "Pflichtfeld nicht angegeben" ("Mandatory field not specified").

I think there was some ambiguity in the docs in this area at the time this was first written, so I'll revisit it now and see if there are any special requirements here for capture of other payment types. Also some tests covering this area would be good.

@judgej judgej merged commit 55e733e into academe:master Aug 4, 2018
judgej added a commit that referenced this pull request Aug 4, 2018
Additional tests for capture of other payment types are needed too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants