fix querier panics when query exemplars (cortexproject#4473)

* fix querier panics when query exemplars Signed-off-by: nous23 <[email protected]> * Update CHANGELOG.md Co-authored-by: Peter Štibraný <[email protected]> Signed-off-by: nous23 <[email protected]> Co-authored-by: Peter Štibraný <[email protected]> Signed-off-by: Alvin Lin <[email protected]>
ac1214 · Jan 14, 2022 · 2de54a3 · 2de54a3
1 parent 32810ed
commit 2de54a3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -76,7 +76,11 @@
 =======
 * [BUGFIX] Memberlist: forward only changes, not entire original message. #4419
 * [BUGFIX] Memberlist: don't accept old tombstones as incoming change, and don't forward such messages to other gossip members. #4420
+<<<<<<< HEAD
 >>>>>>> Clean up some changelog entries (#4458)
+=======
+* [BUGFIX] Querier: fixed panic when querying exemplars and using `-distributor.shard-by-all-labels=false`. #4473
+>>>>>>> fix querier panics when query exemplars (#4473)
 
 ## 1.10.0 / 2021-08-03
 

diff --git a/pkg/distributor/query.go b/pkg/distributor/query.go
@@ -59,7 +59,7 @@ func (d *Distributor) QueryExemplars(ctx context.Context, from, to model.Time, m
 		}
 
 		// We ask for all ingesters without passing matchers because exemplar queries take in an array of array of label matchers.
-		replicationSet, err := d.GetIngestersForQuery(ctx, nil)
+		replicationSet, err := d.GetIngestersForQuery(ctx)
 		if err != nil {
 			return err
 		}